Backport of #963: Fix update krew-index job #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The job did not get triggered when the 0.17.1 release was created. We were using the "on push tags" event trigger however this seems to apply if "git push" is used. We actually use "gh release create" so we need to use the "on release published" event trigger (I verified this works via a test job on my fork). - The krew-release-bot action failed b/c it could not find our .krew.yaml file. We need to first check out the "releases" repository. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
requested review from
mkolesnik,
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr964/tpantelis/backport_963 |
dfarrell07
approved these changes
Apr 18, 2024
|
🤖 Closed branches: [z_pr964/tpantelis/backport_963] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #963 on release-0.17.