Match Ginkgo signatures for By and Fail #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skitt
requested review from
Oats87,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr1612/skitt/match-ginkgo-by-fail |
skitt
force-pushed
the
match-ginkgo-by-fail
branch
from
1b8a481 to
9ac3150
Compare
This allows the framework to use the Ginkgo functions directly, avoiding an extra call (which would affect call stacks in callbacks). Signed-off-by: Stephen Kitt <[email protected]>
skitt
force-pushed
the
match-ginkgo-by-fail
branch
from
9ac3150 to
6a84c9f
Compare
tpantelis
approved these changes
Apr 3, 2024
dfarrell07
approved these changes
Apr 3, 2024
|
🤖 Closed branches: [z_pr1612/skitt/match-ginkgo-by-fail] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the framework to use the Ginkgo functions directly, avoiding an extra call (which would affect call stacks in callbacks).