Listener pod ncat fix #1773
Closed
Listener pod ncat fix #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the Busybox compatible nc script is used instead of ncat. Signed-off-by: Stephen Kitt <[email protected]>
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.29.0 to 0.31.0. - [Commits](golang/crypto@v0.29.0...v0.31.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Stephen Kitt <[email protected]>
`ncat -w` defaults to seconds but gives a warning when unit not explicitly specified. This causes errors in msg exchanged between listener and connect pods. Explicitly specify unit as seconds when passing arg to `ncat -w` to avoid the warning and resulting errors. Signed-off-by: Vishal Thapar <[email protected]>
vthapar
requested review from
mkolesnik,
Oats87,
skitt,
sridhargaddam and
tpantelis
as code owners
|
🤖 Created branch: z_pr1773/vthapar/listener-pod-ncat-fix |
`-s` and `-p` flags are not supported with listen mode with ncat. Note: This should be handled by `nc` script but doesn't seem to be working. Once it works, revert this change so it works with older versions of nettest/ncat. Signed-off-by: Vishal Thapar <[email protected]>
skitt
requested changes
Dec 17, 2024
| @@ -278,7 +278,7 @@ func (np *NetworkPod) buildTCPCheckListenerPod() { | |||
| "for i in $(seq 1 $BUFS_NUM);" + | |||
| " do echo [dataplane] listener says $SEND_STRING;" + | |||
| " done" + | |||
| " | nc -w $CONN_TIMEOUT -l -v -p $LISTEN_PORT -s 0.0.0.0 >/dev/termination-log 2>&1", | |||
| " | nc -w ${CONN_TIMEOUT}s -l -v 0.0.0.0 $LISTEN_PORT >/dev/termination-log 2>&1", | |||
There was a problem hiding this comment.
Suggested change
| " | nc -w ${CONN_TIMEOUT}s -l -v 0.0.0.0 $LISTEN_PORT >/dev/termination-log 2>&1", | |
| " | ncat -w ${CONN_TIMEOUT}s -l -v 0.0.0.0 $LISTEN_PORT >/dev/termination-log 2>&1", |
There was a problem hiding this comment.
I want to see if it fails or not. If it works, I'd revert to nc syntax so it works with older images, as you pointed out earlier. It will also be a good way to see if script works or not.
| @@ -328,7 +328,7 @@ func (np *NetworkPod) buildTCPCheckConnectorPod() { | |||
| "for in in $(seq 1 $BUFS_NUM);" + | |||
| " do echo [dataplane] connector says $SEND_STRING; done" + | |||
| " | for i in $(seq $CONN_TRIES);" + | |||
| " do if nc -v $REMOTE_IP $REMOTE_PORT -w $CONN_TIMEOUT;" + | |||
| " do if nc -v $REMOTE_IP $REMOTE_PORT -w ${CONN_TIMEOUT}s;" + | |||
There was a problem hiding this comment.
Suggested change
| " do if nc -v $REMOTE_IP $REMOTE_PORT -w ${CONN_TIMEOUT}s;" + | |
| " do if ncat -v $REMOTE_IP $REMOTE_PORT -w ${CONN_TIMEOUT}s;" + |
|
🤖 Closed branches: [z_pr1773/vthapar/listener-pod-ncat-fix] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.