-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes for operator-sdk version upgrade epic #2323
Conversation
🤖 Created branch: z_pr2323/Jaanki/sdk_upgrade_rn |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we’d said the Operator SDK changes didn’t need release notes, since they’re not user-visible. Has that changed?
I wasn't aware of this decision. Anyways, I think the path change for APIs should be mentioned. It could be used by other projects. |
* operator-sdk version is upgraded to 1.23.0. | ||
* Submariner-operator APIs are converted to single-group. Meaning, API definitions can now be found under `api/`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* operator-sdk version is upgraded to 1.23.0. | |
* Submariner-operator APIs are converted to single-group. Meaning, API definitions can now be found under `api/`. | |
* The project was rebuilt using Operator SDK version 1.23.0. | |
* The operator APIs have been converted to single-group; projects depending on these will need to | |
replace `github.com/submariner-io/submariner-operator/api/submariner/v1alpha1` with | |
`github.com/submariner-io/submariner-operator/api/v1alpha1` in their imports. |
epic: submariner-io/enhancements#81 Signed-off-by: Janki Chhatbar <[email protected]>
07d523f
to
4f72591
Compare
Also discussing this on slack. We've stated and agreed in the past that RNs are for end users. A Go API change is not for end users. We've many Go API changes in the past sans RN. Let's stay consistent. |
As a follow-up, to notify possible users of the submariner-operator project of the API change, we could add a note to the project release tag once that's created. |
🤖 Closed branches: [z_pr2323/Jaanki/sdk_upgrade_rn] |
submariner-io/enhancements#81
Signed-off-by: Janki Chhatbar [email protected]