Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Calico IPPools deletecollection in RouteAgent RBAC #2856

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Enable Calico IPPools deletecollection in RouteAgent RBAC #2856

merged 2 commits into from
Oct 30, 2023

Conversation

yboaron
Copy link
Contributor

@yboaron yboaron commented Oct 25, 2023

When Submariner is uninstalled the Calico IPPools
are deleted using DeleteCollection command.

This PR updates submariner-routeagent RBAC to support IPPools deletecollection.

@yboaron
Add support for Calico IPPools deletecollection
520e555 
When Submariner is uninstalled the Calico IPPools
are deleted using DeleteCollection command.

This PR updates submariner-routeagent RBAC to support
IPPools deletecollection.

Signed-off-by: Yossi Boaron <[email protected]>
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2856/yboaron/calico_deletecollection
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@yboaron yboaron marked this pull request as ready for review October 25, 2023 12:55
@yboaron yboaron changed the title Add support for Calico IPPools deletecollection Enable Calico IPPools deletecollection in RouteAgent RBAC Oct 26, 2023
@yboaron yboaron mentioned this pull request Oct 26, 2023
Merged
@yboaron yboaron added Calico backport This change requires a backport to eligible release branches labels Oct 29, 2023
@yboaron
Copy link
Contributor Author

yboaron commented Oct 30, 2023

cc @skitt @tpantelis

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Oct 30, 2023
@tpantelis tpantelis enabled auto-merge (rebase) October 30, 2023 11:52
@tpantelis tpantelis merged commit ecaa61a into submariner-io:devel Oct 30, 2023
42 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2856/yboaron/calico_deletecollection]

@sridhargaddam sridhargaddam mentioned this pull request Oct 31, 2023
Merged
@dfarrell07
Copy link
Member

This was backported to 0.16: #2861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpantelis tpantelis tpantelis approved these changes

@skitt skitt skitt approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

Assignees
No one assigned
Labels
backport This change requires a backport to eligible release branches backport-handled Calico ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yboaron @submariner-bot @dfarrell07 @skitt @tpantelis