Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump default E2E K8s version from 1.28 to 1.29 #2947

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Bump default E2E K8s version from 1.28 to 1.29 #2947

merged 2 commits into from
Feb 6, 2024

Conversation

tpantelis
Copy link
Contributor

@tpantelis tpantelis commented Jan 25, 2024 •
edited by skitt
Loading

@tpantelis tpantelis self-assigned this Jan 25, 2024
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2947/tpantelis/e2e_1.29
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@skitt
Copy link
Member

skitt commented Jan 25, 2024

We’ll need a newer kind release with 1.29 images before this can work. Note that the default E2E GHA relies on Shipyard’s default; see submariner-io/shipyard#1538.

@tpantelis tpantelis added the ready-to-test When a PR is ready for full E2E testing label Jan 25, 2024
@tpantelis
Copy link
Contributor Author

We’ll need a newer kind release with 1.29 images before this can work

I figured that.

@tpantelis tpantelis marked this pull request as draft January 25, 2024 14:07
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

This PR/issue depends on:

@skitt skitt marked this pull request as ready for review February 6, 2024 12:11
@skitt skitt requested a review from vthapar as a code owner February 6, 2024 12:11
@tpantelis tpantelis enabled auto-merge (rebase) February 6, 2024 13:33
@tpantelis tpantelis merged commit 546c37f into submariner-io:devel Feb 6, 2024
35 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2947/tpantelis/e2e_1.29]

@tpantelis tpantelis deleted the e2e_1.29 branch May 21, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aswinsuryan aswinsuryan aswinsuryan approved these changes

@skitt skitt skitt approved these changes

@mkolesnik mkolesnik Awaiting requested review from mkolesnik mkolesnik is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@sridhargaddam sridhargaddam Awaiting requested review from sridhargaddam sridhargaddam is a code owner

@vthapar vthapar Awaiting requested review from vthapar vthapar is a code owner

Assignees

@tpantelis tpantelis

Labels
ready-to-test When a PR is ready for full E2E testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tpantelis @submariner-bot @skitt @aswinsuryan