-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that dependencies don't include unmerged commits #3237
Conversation
🤖 Created branch: z_pr3237/skitt/dummy-change |
7cdea92
to
a8314c9
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
I see the submariner-io/shipyard#1730 PR is merged. What's the plan for other repos? |
I’m updating this PR to use the merged script; once that’s done I’ll replicate the PR on the other repos. |
d3a1ca0
to
71724bd
Compare
Looks like it worked! |
This ensures that the project doesn't end up depending on commits that aren't present in the corresponding branch of the dependency. This is useful to prevent merging with pre-rebase commits from cross-project changes; it also ensures that malicious commits from forks can't end up references in the main projects. Signed-off-by: Stephen Kitt <[email protected]>
This PR/issue depends on:
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
Two jobs failed, re-running. |
🤖 Closed branches: [z_pr3237/skitt/dummy-change] |
This ensures that the project doesn't end up depending on commits that aren't present in the corresponding branch of the dependency. This is useful to prevent merging with pre-rebase commits from cross-project changes; it also ensures that malicious commits from forks can't end up references in the main projects.
Depends on submariner-io/shipyard#1739