Enhance flannel discovery by listing DaemonSets across all namespaces #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswinayyolath
requested review from
Oats87,
skitt,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr3268/aswinayyolath/3210-enhance-flannel-discovery |
|
It would be nice if someone can review the code.. This is done as part below linked issue |
|
@aswinayyolath Thanks for contributing! If you want to verify the change locally, you can
|
|
ohh Thats great! thanks a lot @yboaron for the info I will give it a go |
|
@yboaron I can't find the mentioned path in this repo subctl repo No flannel.go in subctlBut it's there in
|
|
Okay I found it after downloading all the packages locally using |
aswinayyolath
force-pushed
the
3210-enhance-flannel-discovery
branch
2 times, most recently
from
58e1faf to
b99b801
Compare
Before change
After Change
The CNI is correctly getting identified as Flannel now |
Running unit testsAll unit tests Passed |
yboaron
reviewed
Nov 10, 2024
yboaron
reviewed
Nov 10, 2024
Cool! |
vthapar
approved these changes
Nov 11, 2024
| @@ -63,10 +63,13 @@ var flannelDaemonSet = appsv1.DaemonSet{ | |||
| ObjectMeta: metav1.ObjectMeta{ | |||
| Name: "kube-flannel-ds", | |||
| Namespace: metav1.NamespaceSystem, | |||
| Labels: map[string]string{"k8s-app": "flannel"}, | |||
There was a problem hiding this comment.
Should add a test case for DaemonSet without flannel label returning a generic plugin.
There was a problem hiding this comment.
Added the test
tpantelis
approved these changes
Nov 11, 2024
auto-merge was automatically disabled
November 11, 2024 14:27
Head branch was pushed to by a user without write access
aswinayyolath
force-pushed
the
3210-enhance-flannel-discovery
branch
from
c9a4091 to
358d1f3
Compare
aswinayyolath
requested review from
aswinsuryan,
dfarrell07 and
maayanf24
as code owners
aswinayyolath
force-pushed
the
3210-enhance-flannel-discovery
branch
from
358d1f3 to
a2467f4
Compare
auto-merge was automatically disabled
November 11, 2024 15:09
Head branch was pushed to by a user without write access
|
Thanks for approving the PR. I need to fix below go lint issues as well. I will make required changes! 
|
yboaron
approved these changes
Nov 11, 2024
Signed-off-by: Aswin A <[email protected]> Contributes to: submariner-io/submariner#3210
tpantelis
force-pushed
the
3210-enhance-flannel-discovery
branch
from
67f8022 to
fd28439
Compare
|
🤖 Closed branches: [z_pr3268/aswinayyolath/3210-enhance-flannel-discovery] |
dfarrell07
added
the
release-note-needed
|
@aswinayyolath thanks for the PR! We think this should have a release note. Would you like to add it? We can show you the process if needed. |
|
Yes please, I will add that. Pls share me the details |
In the https://github.com/submariner-io/submariner-website project, create a branch off of the release-notes-0.20 branch. In the _src/content/community/releases/index.en.md file, under the |
|
Created a PR: submariner-io/submariner-website#1203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aswin A [email protected]
Contributes to: submariner-io/submariner#3210