-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up a base distribution in the images #3292
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
#!/bin/bash | ||
|
||
# Installs packages using dnf to a named root: | ||
# -a arch - use arch instead of the native arch | ||
# -k - keep the package cache | ||
# -r root - install to the named root instead of /output/base | ||
# -v ver - use the given Fedora version (required) | ||
# | ||
# %arch in the package references will be replaced with the chosen arch | ||
|
||
INSTALL_ROOT=/output/base | ||
|
||
# Limit the number of files so that dnf doesn't spend ages processing fds | ||
ulimit -n 1048576 | ||
|
||
while getopts a:kr:v: o | ||
do | ||
case "$o" in | ||
a) | ||
ARCH="$OPTARG" | ||
;; | ||
k) | ||
KEEP_CACHE=true | ||
;; | ||
r) | ||
INSTALL_ROOT="$OPTARG" | ||
;; | ||
v) | ||
FEDORA_VERSION="$OPTARG" | ||
;; | ||
*) | ||
echo "$0 doesn't support $o" >&2 | ||
exit 1 | ||
;; | ||
esac | ||
done | ||
shift $((OPTIND - 1)) | ||
|
||
if [[ -n "${ARCH}" ]]; then | ||
# Convert container arch to Fedora arch | ||
ARCH="${ARCH##*/}" | ||
case "${ARCH}" in | ||
amd64) ARCH=x86_64;; | ||
arm64) ARCH=aarch64;; | ||
esac | ||
arch_args="--forcearch ${ARCH}" | ||
else | ||
# This will be used later, but we won't force | ||
ARCH="$(rpm -q --qf "%{arch}" rpm)" | ||
fi | ||
|
||
[[ -z "${FEDORA_VERSION}" ]] && echo I need to know which version of Fedora to install, specify it with -v >&2 && exit 1 | ||
|
||
if [[ "${INSTALL_ROOT}" != /output/base ]] && [[ ! -d "${INSTALL_ROOT}" ]] && [[ -d /output/base ]]; then | ||
cp -a /output/base "${INSTALL_ROOT}" | ||
fi | ||
|
||
dnf -y --setopt=install_weak_deps=0 --nodocs ${arch_args} \ | ||
--installroot "${INSTALL_ROOT}" --releasever "${FEDORA_VERSION}" \ | ||
install "${@//\%arch/${ARCH}}" | ||
|
||
[[ "${KEEP_CACHE}" == true ]] || dnf -y ${arch_args} --installroot "${INSTALL_ROOT}" --releasever "${FEDORA_VERSION}" clean all |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this have the conditional to prevent trying to raise the limit?
https://github.com/submariner-io/submariner/pull/3241/files#diff-97c33edf909bead8e6d1991b438dcae867427a84e03274fc08cd5edb45de9362R16
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, what I really need to do is move
dnf_install
to Shipyard and unify it.