Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated backport of #2763: Improvements to the Gateway leader election #2777

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Automated backport of #2763: Improvements to the Gateway leader election #2777

merged 8 commits into from
Oct 31, 2023

Conversation

tpantelis
Copy link
Contributor

Backport of #2763 on release-0.16.

#2763: Bump admiral and shipyard versions

For details on the backport process, see the backport requests page.

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2777/tpantelis/automated-backport-of-#2763-upstream-release-0.16
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@tpantelis tpantelis changed the title Automated backport of #2763: Bump admiral and shipyard versions Automated backport of #2763: Improvements to the Gateway leader election Oct 30, 2023
@tpantelis
Bump admiral and shipyard versions
f89bb96 
Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis
Use admiral's LeaderElectionSupport
2c1d078 
Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis
Modify fake ConnectToEndpoint to record the disvovered NAT info
08722a3 
...in the Connection.

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis
Add method to health checker to stop the pingers
4755a24 
Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis
Add Stop method to the cable Engine
d9f831a 
This sets it in a non-running state so it appears to be passive with no
connections. The driver and other internal state is kept to maintain
continuity on restart.

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis
Restart leader election on lease renewal failure in gateway
51f2246 
...rather than exiting.

Related to submariner-io#2747

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis
Add E2E test for leader election renewal failure
cb52bb9 
To simulate a lease update failure, remove the update permission from
the submariner-gateway Role.

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis
Bump default LeaseDuration to 15s, RenewDeadline to 10s
1dba792 
Refer to submariner-io#2747

Signed-off-by: Tom Pantelis <[email protected]>
@tpantelis tpantelis force-pushed the automated-backport-of-#2763-upstream-release-0.16 branch from 2b73dae to 1dba792 Compare October 30, 2023 18:20
@tpantelis tpantelis enabled auto-merge (rebase) October 30, 2023 18:47
@dfarrell07 dfarrell07 added the ready-to-test When a PR is ready for full E2E testing label Oct 30, 2023
@tpantelis tpantelis disabled auto-merge October 30, 2023 23:31
@tpantelis
Copy link
Contributor Author

Several of the E2E tests panicked:

E1030 22:14:58.113607   10400 runtime.go:79] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
goroutine 568 [running]:
k8s.io/apimachinery/pkg/util/runtime.logPanic({0x1854d80?, 0x29bf020})
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/runtime/runtime.go:75 +0x99
k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0x0?})
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/runtime/runtime.go:49 +0x75
panic({0x1854d80, 0x29bf020})
	/usr/lib/golang/src/runtime/panic.go:884 +0x213
k8s.io/apimachinery/pkg/util/runtime.HandleCrash({0x0, 0x0, 0xc0007ab8f0?})
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/runtime/runtime.go:56 +0xd7
panic({0x1854d80, 0x29bf020})
	/usr/lib/golang/src/runtime/panic.go:884 +0x213
github.com/submariner-io/shipyard/test/e2e/framework.(*Framework).AwaitGatewayFullyConnected.func2({0x1a6b960?, 0x0})
	/go/pkg/mod/github.com/submariner-io/[email protected].[2023](https://github.com/submariner-io/submariner/actions/runs/6699251982/job/18203055122?pr=2777#step:3:2039)1025063959-1e68200a75e6/test/e2e/framework/gateways.go:126 +0xb4

The Gateway resource did not yet exist. I submitted submariner-io/shipyard#1447 to address it although I'm not sure why this is occurring now as this code has been around quite a while.

@sridhargaddam sridhargaddam merged commit 3f4a3ba into submariner-io:release-0.16 Oct 31, 2023
32 of 39 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2777/tpantelis/automated-backport-of-#2763-upstream-release-0.16]

@tpantelis tpantelis added release-note-needed Should be mentioned in the release notes release-note-handled labels Nov 2, 2023
@tpantelis tpantelis deleted the automated-backport-of-#2763-upstream-release-0.16 branch December 8, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaanki Jaanki Jaanki approved these changes

@sridhargaddam sridhargaddam sridhargaddam approved these changes

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

@skitt skitt Awaiting requested review from skitt skitt is a code owner

Assignees
No one assigned
Labels
automated-backport ready-to-test When a PR is ready for full E2E testing release-note-handled release-note-needed Should be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tpantelis @submariner-bot @sridhargaddam @Jaanki @dfarrell07