-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump k8s.io/component-helpers from 0.29.3 to 0.30.0 in the gomod group #2985
Conversation
go.mod
Outdated
@@ -1,6 +1,7 @@ | |||
module github.com/submariner-io/submariner | |||
|
|||
go 1.21 | |||
toolchain go1.22.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's interesting this toolchain directive gets introduced by this PR. I'm a bit surprised, as we already had golang 1.21 here which introduced the feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
K8s 0.30 requires Go 1.22. We should just update to go 1.22
and remove the toolchain directive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
71b53cf
to
35e1bff
Compare
Should we remove the toolchain line? |
go.mod
Outdated
|
||
toolchain go1.22.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I did
Bumps the gomod group with 1 update: [k8s.io/component-helpers](https://github.com/kubernetes/component-helpers). Updates `k8s.io/component-helpers` from 0.29.3 to 0.30.0 - [Commits](kubernetes/component-helpers@v0.29.3...v0.30.0) --- updated-dependencies: - dependency-name: k8s.io/component-helpers dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod ... Signed-off-by: dependabot[bot] <[email protected]>
35e1bff
to
161ca00
Compare
Bumps the gomod group with 1 update: k8s.io/component-helpers.
Updates
k8s.io/component-helpers
from 0.29.3 to 0.30.0Commits
e1277e8
Update dependencies to v0.30.0 tag7c78723
Merge remote-tracking branch 'origin/master' into release-1.309e849fb
Update x/net for CVE-2023-45288baf8a99
Bump github.com/golang/protobuf v1.5.4, google.golang.org/protobuf v1.33.0e6e24ac
Merge pull request #123529 from thockin/go-workspacesb61335b
Fix up go.mod files after reviews4a7958d
Remove old gengo detritus565efbc
Re-vendor latest kube-openapi and gengo/v21e267aa
Generate go.work files866cab6
Merge pull request #123348 from hoskeri/update-go-x-crypto-19Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions