Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protoc provided by Shipyard #3240

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

skitt
Copy link
Member

@skitt skitt commented Dec 4, 2024

This avoids relying on a manually-maintained version.

Depends on submariner-io/shipyard#1764

@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr3240/skitt/shipyard-protoc
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

@github-actions github-actions bot removed the dependent label Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

This PR/issue depends on:

This avoids relying on a manually-maintained version.

Signed-off-by: Stephen Kitt <[email protected]>
@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Dec 10, 2024
@tpantelis tpantelis merged commit 0df358d into submariner-io:devel Dec 11, 2024
39 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr3240/skitt/shipyard-protoc]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-test When a PR is ready for full E2E testing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants