-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make supported types in dialect yaml files as a map #81
Changes from 4 commits
b56c356
51b5bb7
d3aeb37
9d1df84
c976045
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,20 +26,34 @@ dependencies: | |
string: | ||
https://github.com/substrait-io/substrait/blob/main/extensions/substrait/extensions/functions_string.yaml | ||
supported_types: | ||
- i8 | ||
- i16 | ||
- i32 | ||
- i64 | ||
- fp32 | ||
- fp64 | ||
- bool | ||
- str | ||
- date | ||
- time | ||
- ts | ||
- tstz | ||
- interval | ||
- dec | ||
i8: | ||
sql_type_name: TINYINT, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the trailing comma needed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed it |
||
i16: | ||
sql_type_name: SMALLINT | ||
i32: | ||
sql_type_name: INTEGER | ||
i64: | ||
sql_type_name: BIGINT | ||
fp32: | ||
sql_type_name: REAL | ||
fp64: | ||
sql_type_name: DOUBLE | ||
bool: | ||
sql_type_name: BOOLEAN | ||
str: | ||
sql_type_name: VARCHAR | ||
date: | ||
sql_type_name: DATE | ||
time: | ||
sql_type_name: TIME | ||
ts: | ||
sql_type_name: TIMESTAMP | ||
tstz: | ||
sql_type_name: TIMESTAMPTZ | ||
interval: | ||
sql_type_name: INTERVAL | ||
decimal: | ||
sql_type_name: DECIMAL | ||
scalar_functions: | ||
- name: arithmetic.add | ||
local_name: + | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,18 +26,30 @@ dependencies: | |
string: | ||
https://github.com/substrait-io/substrait/blob/main/extensions/substrait/extensions/functions_string.yaml | ||
supported_types: | ||
- i16 | ||
- i32 | ||
- i64 | ||
- fp32 | ||
- fp64 | ||
- bool | ||
- str | ||
- date | ||
- time | ||
- ts | ||
- tstz | ||
- interval | ||
i16: | ||
sql_type_name: smallint | ||
i32: | ||
sql_type_name: integer | ||
i64: | ||
sql_type_name: bigint | ||
fp32: | ||
sql_type_name: float4 | ||
fp64: | ||
sql_type_name: float8 | ||
bool: | ||
sql_type_name: boolean | ||
str: | ||
sql_type_name: text | ||
date: | ||
sql_type_name: date | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why are these type names lowercase while most of the other dialects are capitalized? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. changed everything to lower case. |
||
time: | ||
sql_type_name: time | ||
ts: | ||
sql_type_name: timestamp | ||
tstz: | ||
sql_type_name: timestamptz | ||
interval: | ||
sql_type_name: interval | ||
scalar_functions: | ||
- name: arithmetic.add | ||
local_name: + | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the underscore in SQL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this from runner.py