Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for bitwise and/or/xor for decimal type #85

Closed

Conversation

anshuldata
Copy link
Contributor

@anshuldata anshuldata commented Jul 31, 2024

  • duckdb doesn't support bitwise and/or/xor for decimal type so not supported in duckdb dialect
  • Currently I am focusing on Snowflake and Duckdb dialect so skipped other dialects for now.
  • Set scale/precision based on Substrait spec (here) which is as follows for bitwise_and/or/xor :
    Input: (<P1, 0>, <P2, 0>) ==> Result: <max(P1, P2), 0>)

@anshuldata
Copy link
Contributor Author

@richtia kindly check

@anshuldata
Copy link
Contributor Author

anshuldata commented Aug 13, 2024

@richtia I have fixed precision in this PR. Kindly check. Thanks

Set scale/precision based on Substrait spec (here) which is as follows for bitwise_and/or/xor :
Input: (<P1, 0>, <P2, 0>) ==> Result: <max(P1, P2), 0>)

Scale/Precision for bitwise_and/or/xor is as follows
Input: (<P1, 0>, <P2, 0>) ==> Result: <max(P1, P2), 0>)
@anshuldata
Copy link
Contributor Author

  1. Build site is failing because we moved substrait submodule
  2. Run tests with postgres/velox is failing because of "docker-compose: command not found". What is not clear to me why it suddenly started failing
    can you check these @richtia

@anshuldata
Copy link
Contributor Author

Closing this PR since raised this PR against migrated repo

@anshuldata anshuldata closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant