Add test cases for comparison functions with decimal arguments #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anshuldata
commented
Aug 1, 2024
•
anshuldata
commented
- Added test cases for comparison function with decimal arguments
- Fixed a bug (regression in this PR) where unsupported dialect type should return error. Dialect checks for "None" if type is unsupported. In previous PR I changed it to throw exception (e.g. here and here) hence snowflake tests were failing for unsupported type (i.e. i8)
- Kept precision/scale same as substriat. All input type is "any" so type really doesn't matter. For Result type is either "any" or "boolean" so no specific care needed in type for decimal
anshuldata
changed the title
anshuldata
force-pushed
the
SfComparisonDecimal
branch
from
21d50d5
to
e52f16b
Compare
anshuldata
changed the title
|
@richtia kindly review |
|
@richtia I think this PR needs to be merged first, since it fixes a regression |
richtia
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.