Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for aggregate arithmetic function "sum/min/max" having decimal argumets #88

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Add test cases for aggregate arithmetic function "sum/min/max" having decimal argumets #88

merged 3 commits into from
Aug 22, 2024

Commits on Aug 22, 2024

  1. Add test cases for aggregate arithmetic function "sum/min/max/avg" ha… 

    …ving decimal argumets
    @anshuldata @jacques-n
    anshuldata authored and jacques-n committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    62dc359 View commit details
    Browse the repository at this point in the history

  2. Fix Decimal comparision to load decimal value at load time instead of… 

    … check time

* Added custom tag "!decimal" and "!decimallist" and use them to load decimal value as decimal
    @anshuldata @jacques-n
    anshuldata authored and jacques-n committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    7ba6207 View commit details
    Browse the repository at this point in the history

  3. Make input type and result type same as substrait which is as follows 

    Sum:
  Input DECIMAL<P, S> ==> Result: DECIMAL<38, S>
Min:
  Input DECIMAL<P, S> ==> Result: DECIMAL<P, S>
Max:
  Input DECIMAL<P, S> ==> Result: DECIMAL<P, S>
* Remove average test cases for now. Their return type doesn't seem to be conform to Substrait
* I will raise avg in a separate PR
    @anshuldata @jacques-n
    anshuldata authored and jacques-n committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    bb4755b View commit details
    Browse the repository at this point in the history