Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to add arm to github action #106

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

try to add arm to github action #106

wants to merge 4 commits into from

Conversation

jacques-n
Copy link
Contributor

No description provided.

@jacques-n
Copy link
Contributor Author

Wow, it took 90m to build on macos

???

@EpsilonPrime
Copy link
Member

EpsilonPrime commented Jul 26, 2024 via email

@EpsilonPrime
Copy link
Member

It is odd that the required "build" option is still pending and that build was renamed to linux-build. I don't see an option to change the required builds in the repo though.

@jacques-n
Copy link
Contributor Author

Running again to see if performance continues to be bad.

It is odd that the required "build" option is still pending and that build was renamed to linux-build. I don't see an option to change the required builds in the repo though.

That's something configured inside the Github UI afaik. I changed the names to be clearer around steps but would need to change at the repo level as well if we decide to merge this.

Will wait to see if perf was a random problem or constant. If constant I'm inclined to shelve this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

@westonpace westonpace Awaiting requested review from westonpace westonpace is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacques-n @EpsilonPrime