Update proto definition to v0.55.0 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anshuldata
commented
Aug 19, 2024
anshuldata
commented
- Fixed name of Join type which was breaking change. Updated in This PR updated these types PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 52.33% 52.31% -0.02%
==========================================
Files 21 21
Lines 6011 6013 +2
==========================================
Hits 3146 3146
- Misses 2676 2678 +2
Partials 189 189 ☔ View full report in Codecov by Sentry. |
| @@ -607,14 +607,14 @@ func (j *JoinRel) RecordType() types.StructType { | |||
| switch j.joinType { | |||
There was a problem hiding this comment.
Are you going to need JoinTypeRightSingle and JoinTypeRightAnti for all of the options to be handled without a default clause?
There was a problem hiding this comment.
This PR I intended to keep for proto change so I planned to handle them in a separate PR. I updated PR to add missing ones to indicate unsupported. Kindly check
jacques-n
approved these changes
Aug 19, 2024
zeroshade
approved these changes
Aug 19, 2024
jacques-n
force-pushed
the
anshul/UpdateProto0.55.0
branch
from
4e7dd91
to
eeed6a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.