Add Match and MatchAt API to FunctionVariant interface #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anshuldata
commented
Sep 4, 2024
•
anshuldata
commented
- fixed default nullability for ScalarFunctionImpl if nullability is not provided
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 55.79% 55.13% -0.67%
==========================================
Files 35 35
Lines 6778 6861 +83
==========================================
+ Hits 3782 3783 +1
- Misses 2806 2885 +79
- Partials 190 193 +3 ☔ View full report in Codecov by Sentry. |
jacques-n
reviewed
Sep 5, 2024
anshuldata
changed the title
|
I will un-draft once #53 is merged and is rebased for this PR |
anshuldata
force-pushed
the
anshul/AddMatchFuncVariantAPI
branch
3 times, most recently
from
ff0c6b6
to
94687c0
Compare
* Also fixed default nullability for ScalarFunctionImpl
anshuldata
force-pushed
the
anshul/AddMatchFuncVariantAPI
branch
from
94687c0
to
fc1a169
Compare
anshuldata
changed the title
|
This PR is ready for review |
jacques-n
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.