treat default of supported_as_column as true in dialect #56
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage 55.13% 55.13%
=======================================
Files 35 35
Lines 6861 6870 +9
=======================================
+ Hits 3783 3788 +5
- Misses 2885 2887 +2
- Partials 193 195 +2 ☔ View full report in Codecov by Sentry. |
functions/dialect.go
Outdated
| } | ||
|
|
||
| type dialectTypeInfo struct { | ||
| SqlTypeName string `yaml:"sql_type_name"` | ||
| SupportedAsColumn bool `yaml:"supported_as_column"` | ||
| SupportedAsColumn *bool `yaml:"supported_as_column" default:"true"` |
There was a problem hiding this comment.
let's avoid change to pointer
There was a problem hiding this comment.
This is needed for SetDefaults to differentiate the zero value from the provided value.
Without this it is incorrectly setting the value to true even if the input is
supported_as_column: false
There was a problem hiding this comment.
Can you resolve this by overriding UnmarshalJSON and having it set the defaults before doing the other operations?
There was a problem hiding this comment.
I tried UnmarshalYAML, one hiccup with this is we cannot use defaults.Set on any struct using dialectTypeInfo. I had to remove defaults.Set on dialectFile.
Looks like whenever we have default:"true" the choice is between 1. using pointer vs 2. adding UnmarshalYAML in all the structs (that includes this bool indirectly) to set the defaults.
LMK 1 or 2?
functions/dialect.go
Outdated
| SupportedAsColumn *bool `yaml:"supported_as_column" default:"true"` | ||
| } | ||
|
|
||
| func (ti *dialectTypeInfo) isSupportedAsColumn() bool { |
There was a problem hiding this comment.
shouldn't need to introduce this if we stay away from pointer.
No description provided.