feat(isthmus): allow WindowFunctionConverter to use a non-default Typ…

…eConverter
substrait-io · Aug 29, 2024 · 19f80ae · 19f80ae
1 parent 2396d68
commit 19f80ae
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/isthmus/src/main/java/io/substrait/isthmus/expression/WindowFunctionConverter.java b/isthmus/src/main/java/io/substrait/isthmus/expression/WindowFunctionConverter.java
@@ -10,6 +10,7 @@
 import io.substrait.expression.WindowBound;
 import io.substrait.extension.SimpleExtension;
 import io.substrait.isthmus.AggregateFunctions;
+import io.substrait.isthmus.TypeConverter;
 import io.substrait.type.Type;
 import java.util.Collections;
 import java.util.List;
@@ -39,6 +40,14 @@ public WindowFunctionConverter(
     super(functions, typeFactory);
   }
 
+  public WindowFunctionConverter(
+      List<SimpleExtension.WindowFunctionVariant> functions,
+      List<FunctionMappings.Sig> additionalSignatures,
+      RelDataTypeFactory typeFactory,
+      TypeConverter typeConverter) {
+    super(functions, additionalSignatures, typeFactory, typeConverter);
+  }
+
   @Override
   protected Expression.WindowFunctionInvocation generateBinding(
       WrappedWindowCall call,

diff --git a/isthmus/src/main/java/io/substrait/isthmus/expression/WindowRelFunctionConverter.java b/isthmus/src/main/java/io/substrait/isthmus/expression/WindowRelFunctionConverter.java
@@ -9,6 +9,7 @@
 import io.substrait.expression.WindowBound;
 import io.substrait.extension.SimpleExtension;
 import io.substrait.isthmus.AggregateFunctions;
+import io.substrait.isthmus.TypeConverter;
 import io.substrait.relation.ConsistentPartitionWindow;
 import io.substrait.type.Type;
 import java.util.List;
@@ -38,6 +39,14 @@ public WindowRelFunctionConverter(
     super(functions, typeFactory);
   }
 
+  public WindowRelFunctionConverter(
+      List<SimpleExtension.WindowFunctionVariant> functions,
+      List<FunctionMappings.Sig> additionalSignatures,
+      RelDataTypeFactory typeFactory,
+      TypeConverter typeConverter) {
+    super(functions, additionalSignatures, typeFactory, typeConverter);
+  }
+
   @Override
   protected ConsistentPartitionWindow.WindowRelFunctionInvocation generateBinding(
       WrappedWindowRelCall call,