Apply suggestions from code review

Co-authored-by: Dane Pitkin <[email protected]>
substrait-io · Nov 29, 2023 · a677e47 · a677e47
1 parent 1d23187
commit a677e47
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/core/src/main/java/io/substrait/extended/expression/ExtendedExpression.java b/core/src/main/java/io/substrait/extended/expression/ExtendedExpression.java
@@ -9,7 +9,7 @@
 
 @Value.Immutable
 public abstract class ExtendedExpression {
-  public abstract List<ExpressionReference> getReferredExpr();
+  public abstract List<ExpressionReference> getReferredExpressions();
 
   public abstract NamedStruct getBaseSchema();
 
@@ -21,7 +21,7 @@ public abstract class ExtendedExpression {
 
   @Value.Immutable
   public abstract static class ExpressionReference {
-    public abstract Expression getReferredExpr();
+    public abstract Expression getExpression();
 
     public abstract List<String> getOutputNames();
   }

diff --git a/core/src/main/java/io/substrait/extended/expression/ExtendedExpressionProtoConverter.java b/core/src/main/java/io/substrait/extended/expression/ExtendedExpressionProtoConverter.java
@@ -15,7 +15,7 @@ public class ExtendedExpressionProtoConverter {
   public ExtendedExpression toProto(
       io.substrait.extended.expression.ExtendedExpression extendedExpression) {
 
-    ExtendedExpression.Builder extendedExpressionBuilder = ExtendedExpression.newBuilder();
+    ExtendedExpression.Builder builder = ExtendedExpression.newBuilder();
     ExtensionCollector functionCollector = new ExtensionCollector();
 
     final ExpressionProtoConverter expressionProtoConverter =