feat(isthmus): support for replace (#224)

substrait-io · Feb 6, 2024 · e96f4ba · e96f4ba
1 parent e63388d
commit e96f4ba
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/isthmus/src/main/java/io/substrait/isthmus/expression/FunctionMappings.java b/isthmus/src/main/java/io/substrait/isthmus/expression/FunctionMappings.java
@@ -58,6 +58,7 @@ public class FunctionMappings {
                 s(SqlStdOperatorTable.FLOOR, "floor"),
                 s(SqlStdOperatorTable.ROUND, "round"),
                 s(SqlStdOperatorTable.LIKE),
+                s(SqlStdOperatorTable.REPLACE, "replace"),
                 s(SqlStdOperatorTable.SUBSTRING, "substring"),
                 s(SqlStdOperatorTable.CONCAT, "concat"),
                 s(SqlStdOperatorTable.CHAR_LENGTH, "char_length"),

diff --git a/isthmus/src/test/java/io/substrait/isthmus/StringFunctionTest.java b/isthmus/src/test/java/io/substrait/isthmus/StringFunctionTest.java
@@ -7,6 +7,9 @@
 public class StringFunctionTest extends PlanTestBase {
 
   static List<String> CREATES = List.of("CREATE TABLE strings (c16 CHAR(16), vc32 VARCHAR(32))");
+  static List<String> REPLACE_CREATES =
+      List.of(
+          "CREATE TABLE replace_strings (c16 CHAR(16), vc32 VARCHAR(32), replace_from VARCHAR(16), replace_to VARCHAR(16))");
 
   @ParameterizedTest
   @ValueSource(strings = {"c16", "vc32"})
@@ -36,6 +39,14 @@ void upper(String column) throws Exception {
     assertSqlSubstraitRelRoundTrip(query, CREATES);
   }
 
+  @ParameterizedTest
+  @ValueSource(strings = {"c16", "vc32"})
+  void replace(String column) throws Exception {
+    String query =
+        String.format("SELECT replace(%s, replace_from, replace_to) FROM replace_strings", column);
+    assertSqlSubstraitRelRoundTrip(query, REPLACE_CREATES);
+  }
+
   @ParameterizedTest
   @ValueSource(strings = {"c16", "vc32"})
   void substringWith1Param(String column) throws Exception {