bug: fix vist of nested struct #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasseGuillaume
force-pushed
the
nested-field-access-bug
branch
4 times, most recently
from
4c43415
to
b4ea5cf
Compare
MasseGuillaume
changed the title
MasseGuillaume
force-pushed
the
nested-field-access-bug
branch
2 times, most recently
from
e346ce7
to
4d3e544
Compare
also fix a bug in ExpressionProtoConverter where we don't keep any of the segments of a nested structure
MasseGuillaume
force-pushed
the
nested-field-access-bug
branch
from
4d3e544
to
525f517
Compare
MasseGuillaume
commented
Jul 13, 2023
|
Ready for review! |
vbarua
reviewed
Jul 13, 2023
isthmus/src/test/java/io/substrait/isthmus/NestedStructQueryTest.java
Outdated
Show resolved
Hide resolved
vbarua
reviewed
Jul 13, 2023
isthmus/src/test/java/io/substrait/isthmus/NestedStructQueryTest.java
Outdated
Show resolved
Hide resolved
vbarua
reviewed
Jul 13, 2023
isthmus/src/test/java/io/substrait/isthmus/NestedStructQueryTest.java
Outdated
Show resolved
Hide resolved
vbarua
reviewed
Jul 13, 2023
isthmus/src/test/java/io/substrait/isthmus/NestedStructQueryTest.java
Outdated
Show resolved
Hide resolved
vbarua
reviewed
Jul 13, 2023
MasseGuillaume
force-pushed
the
nested-field-access-bug
branch
from
e61d7c2
to
22c60eb
Compare
MasseGuillaume
force-pushed
the
nested-field-access-bug
branch
from
22c60eb
to
bc86b59
Compare
|
@jacques-n if you can review this PR, your feedback would be greatly appreciated. |
jacques-n
approved these changes
Aug 2, 2023
EpsilonPrime
added a commit
to substrait-io/substrait
that referenced
this pull request
Nov 22, 2023
related PR: substrait-io/substrait-java#150 --------- Co-authored-by: David Sisson <[email protected]>
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
* feat: add support for nested structs in RexExpressionConverter * fix: ExpressionProtoConverter did not keep segments of nested structs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case will hit:
substrait-java/isthmus/src/main/java/io/substrait/isthmus/expression/RexExpressionConverter.java
Lines 128 to 129 in 4749dca
since
fieldAccess.getReferenceExpr()is aRexFieldAccess