Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add SingleOrList support to the Isthmus converter #159

Merged
merged 3 commits into from
Jul 19, 2023
Merged

feat: Add SingleOrList support to the Isthmus converter #159

merged 3 commits into from
Jul 19, 2023

Conversation

carlyeks
Copy link
Contributor

The expression should use the makeInCall, which will be translated into Calcite as a SEARCH expression.

Added a new test to SubstraitRelNodeConverterTest which fails without this change.

@vbarua vbarua self-requested a review July 17, 2023 17:20
vbarua
vbarua approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Implementation looks reasonable and the checks make me confident that:

  • SQL -> Substrait works
  • Substrait -> Calcite -> Substrait works

@vbarua vbarua merged commit 297c535 into substrait-io:main Jul 19, 2023
@carlyeks carlyeks deleted the single-or-list branch July 19, 2023 01:32
ajegou pushed a commit to ajegou/substrait-java that referenced this pull request Mar 29, 2024
@carlyeks
feat: Add SingleOrList support to the Isthmus converter (substrait-io…
04a91f1 
…#159)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbarua vbarua vbarua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlyeks @vbarua