feat: window function calcite support #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
commented
Aug 30, 2023
| enum Direction { | ||
| PRECEDING, | ||
| FOLLOWING | ||
| R visit(Unbounded unbounded); | ||
| } |
There was a problem hiding this comment.
Direction doesn't have an equivalent in the Substrait spec itself. Calcite has a concept of UNBOUNDED_PRECEDING and UNBOUNDED_FOLLOWING, but those can be reduced to singular Unbounded WindowBound when converting from Calcite to Pojo.
vbarua
commented
Aug 30, 2023
| @@ -5,58 +5,62 @@ | |||
| @Value.Enclosing | |||
| public interface WindowBound { | |||
There was a problem hiding this comment.
Rather than encoding the WindowBound type using a combination of BoundedKind and Direction, I've switched this to 4 classes:
- Preceding
- Following
- Current
- Unbounded
and introduced a WindowBoundVisitor to handle dispatch when converting from these to various other representations.
This representation of Window Bounds:
- More closely matches the spec.
- Reduces the need for casting of WindowBound interfaces to concrete types.
- Reduces cognitive complexity (in my opinion) as users no longer need to reason about 6 different enum combinations (3 bounded kinds * 2 directions), and instead have 4 concrete classes.
vbarua
force-pushed
the
vbarua/window-function-calcite-support
branch
from
469e51b
to
bf91fe4
Compare
EpsilonPrime
approved these changes
Aug 30, 2023
core/src/main/java/io/substrait/expression/proto/ExpressionProtoConverter.java
Outdated
Show resolved
Hide resolved
EpsilonPrime
approved these changes
Aug 31, 2023
vbarua
added a commit
that referenced
this pull request
Sep 6, 2023
feat: support for window bounds type feat: reject IGNORE NULLS BREAKING CHANGE: * windowFunction expression creator now requires window bound type parameter * the WindowBound POJO representation has been reworked to use visitation and more closely match the spec * ExpressionRexConverter now requires a WindowFunctionConverter
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
…rait-io#172) feat: support for window bounds type feat: reject IGNORE NULLS BREAKING CHANGE: * windowFunction expression creator now requires window bound type parameter * the WindowBound POJO representation has been reworked to use visitation and more closely match the spec * ExpressionRexConverter now requires a WindowFunctionConverter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: support for window bounds type
BREAKING CHANGE: