Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extend literal conversion support #183

Merged
merged 3 commits into from
Sep 20, 2023
Merged

feat: extend literal conversion support #183

merged 3 commits into from
Sep 20, 2023

Conversation

vbarua
Copy link
Member

@vbarua vbarua commented Sep 20, 2023

No description provided.

@vbarua
feat(calcite): support VarCharLiteral and FixedBinaryLiteral conversions
7ff3dcd
@vbarua
fix(isthmus): convert StrLiteral to VARCHAR
b5ee4e0 
BREAKING CHANGE: StrLiteral is no longer converted to CHAR(<length>)
@vbarua
fix(isthmus): convert BinaryLiteral to VARBINARY
55cd81d 
BREAKING CHANGE: BinaryLiteral is no longer converted to BINARY<length>)
@vbarua vbarua force-pushed the vbarua/extend-literal-conversion-support branch from 65fb690 to 55cd81d Compare September 20, 2023 21:03
@vbarua
Copy link
Member Author

vbarua commented Sep 20, 2023

Adds Calcite conversion support for VarCharLiteral and FixedBinaryLiteral.

Additionally, forces

  • StrLiteral to be converted to VARCHAR
  • BinaryLiteral to be converted to VARBINARY

Before this, they were converted to

  • CHAR()
  • BINARY()

respectively. If those types are desired, Substrait has the FixedChar and FixedBinary types.

Calcite being a bit to smart when converting these two types results in failures during query planning.

@vbarua vbarua merged commit 6e82f39 into main Sep 20, 2023
7 checks passed
@vbarua vbarua deleted the vbarua/extend-literal-conversion-support branch September 20, 2023 21:37
ajegou pushed a commit to ajegou/substrait-java that referenced this pull request Mar 29, 2024
@vbarua
feat: extend literal conversion support (substrait-io#183)
ed4d893 
feat(calcite): support VarCharLiteral and FixedBinaryLiteral conversions

fix(isthmus): convert StrLiteral to VARCHAR
BREAKING CHANGE: StrLiteral is no longer converted to CHAR(<length>)

fix(isthmus): convert BinaryLiteral to VARBINARY 
BREAKING CHANGE: BinaryLiteral is no longer converted to BINARY<length>)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EpsilonPrime EpsilonPrime EpsilonPrime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbarua @EpsilonPrime