feat: improved ReadRel handling #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of the EMPTY_TYPE caused failures when attempting to convert filters with field reference on VirtualScans, because the field references were seen as out-of-bounds.
vbarua
force-pushed
the
vbarua/read-rel-improvements
branch
from
05a9682
to
01bae08
Compare
vbarua
force-pushed
the
vbarua/read-rel-improvements
branch
from
930addf
to
ecae72f
Compare
vbarua
changed the title
EpsilonPrime
approved these changes
Nov 2, 2023
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
* feat: builder util for equal fn * test: additional ReadRel coverage * fix: rel to proto NamedScan conversion skipped filter * fix: rel to proto VirtualScan conversion skipped filter * fix: proto expression converter should use table schema The use of the EMPTY_TYPE caused failures when attempting to convert filters with field reference on VirtualScans, because the field references were seen as out-of-bounds. * fix: allow proto to rel conversion of empty VirtualScan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.