Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add vulnerability scan to PR build #269

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

bestbeforetoday
Copy link
Contributor

Continue build on vulnerability detection.

Update protobuf dependency to address vulnerabilities:

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@bestbeforetoday
Copy link
Contributor Author

I had to back off from using the OSV-Scanner GitHub Action since multiple scan runs all appear to upload security analysis results with the same name. The current change just uses the osv-scanner CLI command directly and so will not populate the repository's Security tab.

@bestbeforetoday bestbeforetoday marked this pull request as ready for review June 11, 2024 20:58
Continue build on vulnerability detection.

Update protobuf dependency to address vulnerabilities:

- CVE-2022-25647
- CVE-2022-3509
- CVE-2022-3510
- CVE-2022-3171
@vbarua
Copy link
Member

vbarua commented Jun 13, 2024

The current change just uses the osv-scanner CLI command directly and so will not populate the repository's Security tab.

How will we see the results of the scan? Are they added as comments to PRs?

@bestbeforetoday
Copy link
Contributor Author

bestbeforetoday commented Jun 13, 2024

The scan jobs will fail if a vulnerability is detected and will show up as failed build checks against the PR. Unless they are required checks, it should not prevent changes being merged though.

An alternative might be to have a scheduled workflow that runs (perhaps daily) on the main branch content. It depends what you prefer.

Copy link
Member

@vbarua vbarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Thanks for adding this capability to our build ✨

@vbarua vbarua merged commit 925261d into substrait-io:main Jun 13, 2024
12 checks passed
@bestbeforetoday bestbeforetoday deleted the scan branch June 13, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants