feat: check that VirtualTableScan field names correspond to schema #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbarua
force-pushed
the
vbarua/improve-virtual-table-scan-validation
branch
2 times, most recently
from
65374d9 to
505afaa
Compare
vbarua
force-pushed
the
vbarua/improve-virtual-table-scan-validation
branch
from
505afaa to
8bc5997
Compare
vbarua
commented
Jul 18, 2024
| R.list(R.STRING), | ||
| R.map(R.STRING, R.STRING)))) | ||
| R.list(R.struct(R.STRING)), | ||
| R.map(R.struct(R.STRING), R.struct(R.STRING))))) |
There was a problem hiding this comment.
The types here did not match the actual row types, which led to some confusion.
vbarua
commented
Jul 18, 2024
| @@ -24,13 +24,16 @@ public abstract class VirtualTableScan extends AbstractReadRel { | |||
| @Value.Check | |||
| protected void check() { | |||
| var names = getInitialSchema().names(); | |||
|
|
|||
| assert names.size() | |||
| == NamedFieldCountingTypeVisitor.countNames(this.getInitialSchema().struct()); | |||
There was a problem hiding this comment.
It may make more sense to move this check into the NamedStruct itself in the long-term. Avoiding this for now because there's some stuff I'd like to verify around names going to and from Calcite and Substrait.
EpsilonPrime
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.