Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bump Spotless to allow building in Java 21 #292

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

acruise
Copy link
Contributor

@acruise acruise commented Sep 6, 2024

edit: still todo: isthmus native image failure due to java syntax versions... 🙄

edit2: back to ready as I have no idea what's up with CI 🤷

see diffplug/spotless#1819

Fixes #274
May also fix #136

@CLAassistant
Copy link

CLAassistant commented Sep 6, 2024

CLA assistant check
All committers have signed the CLA.

@vbarua vbarua changed the title Bump Spotless to allow building in Java 21 build: bump Spotless to allow building in Java 21 Sep 6, 2024
@acruise acruise marked this pull request as ready for review September 18, 2024 21:21
@acruise acruise marked this pull request as draft September 18, 2024 21:22
@acruise acruise marked this pull request as ready for review September 20, 2024 19:36
@vbarua vbarua merged commit 814f85b into substrait-io:main Sep 20, 2024
11 of 12 checks passed
@acruise acruise deleted the acruise/java-21-build branch September 20, 2024 21:56
mbwhite pushed a commit to mbwhite/substrait-java that referenced this pull request Oct 1, 2024
* build: update com.diffplug.spotless 6.11.0 - 6.19.0
* build: update protobuf 3.25.3 - 3.25.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Support JDK 21 spotlessJava task failures during build
3 participants