feat: always build before testing

substrait-io · Dec 7, 2023 · c013471 · c013471
1 parent 2ce2306
commit c013471
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -1,4 +1,4 @@
-name: substraitJS test
+name: substraitJS
 
 on: [push, pull_request]
 
@@ -26,9 +26,6 @@ jobs:
       - name: Install dependencies
         run: npm ci
 
-      - name: Build project
-        run: npm run build
-
       - name: Run tests
         run: npm run test
 
diff --git a/.nvmrc b/.nvmrc
diff --git a/README.md b/README.md
@@ -43,6 +43,16 @@ nvm use 18.0.0
 
 substrait  -p ../plan.json -o <output path>
 ```
+
+## Testing
+Jest is used for testing the visualization functionality of the library. To run the test, we need
+to use `nvm v18.0.0`
+```
+source ~/.nvm/nvm.sh
+nvm use 18.0.0
+
+npm run test
+```
 
 ## License
 [Apache-2.0 license](https://www.apache.org/licenses/LICENSE-2.0)
diff --git a/package.json b/package.json
@@ -18,7 +18,7 @@
     "prepare": "npm run clean-proto && npm run proto && npm run transpileProto",
     "lint": "eslint '**/*.ts'",
     "lint:fix": "npm run lint -- --fix",
-    "test": "$HOME/.nvm/nvm-exec jest"
+    "test": "npm run build && jest"
   },
   "author": "",
   "license": "Apache-2.0",