Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow ptr_arg when handling protobufs #153

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

EpsilonPrime
Copy link
Member

@EpsilonPrime EpsilonPrime commented Feb 20, 2024

While it would be nice to fix this, the change requires a change to how protobuffers are handled which is not a minor change. Filed #154 to track.

@EpsilonPrime EpsilonPrime changed the title chore(Clippy): Use a slice instead of a new object. chore: use a slice instead of a new object Feb 20, 2024
@EpsilonPrime EpsilonPrime changed the title chore: use a slice instead of a new object chore: allow ptr_arg when handling protobufs Feb 20, 2024
@EpsilonPrime EpsilonPrime merged commit bd02892 into substrait-io:main Feb 26, 2024
37 checks passed
@EpsilonPrime EpsilonPrime deleted the clippy_fix branch February 26, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants