-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps,ci): add protoc
feature to build protoc
from source
#356
Conversation
I'm also going to see if I can add some CI for this feature once I open the PR, which should validate / ensure that the |
cb3c163
to
868ef67
Compare
… protoc Also test with and without vendored protoc
806a074
to
811aa33
Compare
OK, tests pass, this should be ready to review! |
protoc
feature to build protoc
from source
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This is very nice, thank you! |
Thanks, @EpsilonPrime, @mbrobbel and @westonpace! |
Fixes #355, by using the same setup for protoc as substrait-io/substrait-rs.
Testing
I checked locally:
[email protected]
from here, to get the same version as is used in the docs.rs workspace (ubuntu 22.04).PATH="/path/to/downloaded/protobuf/bin:$PATH" cargo doc
Error: Custom { kind: Other, error: "protoc failed: substrait/algebra.proto: This file contains proto3 optional fields, but --experimental_allow_proto3_optional was not set.\n" }
, as seen in thedocs.rs
buildPATH="/path/to/downloaded/protobuf/bin:$PATH" cargo doc --features protoc
, to see it succeedSo this shows that it uses
protobuf-src
correctly. I haven't been able to confirm that the docs.rs metadata works correctly; I haven't been able to reproduce this inside a docs.rs docker container.