Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stop printing unused syscalls in execution report #1787

Merged
merged 2 commits into from
Nov 13, 2024
Merged

feat: stop printing unused syscalls in execution report #1787

merged 2 commits into from
Nov 13, 2024

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Nov 13, 2024 •
edited by yuwen01
Loading

Motivation

Printing unused syscalls just clutters the execution report

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

SP1 Performance Test Results

Branch: aurelien/gro-256-dont-print-unused-syscalls
Commit: aa1c40a
Author: leruaa

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.17 2.81 0.46 24s ✅
ssz-withdrawals 2757356 17.37 125.22 34.73 1m20s ✅
tendermint 12593597 6.73 266.83 99.40 2m9s ✅

yuwen01
yuwen01 approved these changes Nov 13, 2024
View reviewed changes
crates/core/machine/src/utils/prove.rs Outdated Show resolved Hide resolved
@leruaa leruaa merged commit 588286b into dev Nov 13, 2024
14 checks passed
@leruaa leruaa deleted the aurelien/gro-256-dont-print-unused-syscalls branch November 13, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwen01 yuwen01 yuwen01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leruaa @yuwen01