Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clean up NetworkProver environment variables #1790

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Nov 14, 2024

Motivation

We need to remove environment variables as they make SP1 difficult to use in a prod environment.

Solution

I added a NetworkProverClientBuilder builder that handle the equivalent of the following environment variables:

  • SKIP_SIMULATION
  • SP1_PRIVATE_KEY
  • PROVER_NETWORK_RPC

The environment variables are still used in ProverClient::new() for backward compatibility.

I only added a builder for the network builder as there is nothing to build for other provers.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link

github-actions bot commented Nov 14, 2024

SP1 Performance Test Results

Branch: aurelien/gro-272-use-builder-pattern-for-sdk
Commit: d2e073b
Author: leruaa

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.18 2.73 0.46 25s
ssz-withdrawals 2757356 16.56 123.13 34.98 1m19s
tendermint 12593597 6.72 270.32 101.09 2m6s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant