feat: clean up NetworkProver environment variables #1790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to remove environment variables as they make SP1 difficult to use in a prod environment.
Solution
I added a
NetworkProverClientBuilder
builder that handle the equivalent of the following environment variables:SKIP_SIMULATION
SP1_PRIVATE_KEY
PROVER_NETWORK_RPC
The environment variables are still used in
ProverClient::new()
for backward compatibility.I only added a builder for the network builder as there is nothing to build for other provers.
PR Checklist