Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to view the verification key by providing the program name #1794

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Nov 15, 2024

Motivation

Now that the ELF is not in the elf folder it harder to specify the path.

Solution

Adding a --program arg that just need the crate name.

Bonus: If there are multiple targets in the program, they will all be printed.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link

SP1 Performance Test Results

Branch: aurelien/add-program-arg-to-vkey
Commit: 7dd6a78
Author: leruaa

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.17 2.89 0.46 25s
ssz-withdrawals 2757356 17.33 124.37 34.93 1m19s
tendermint 12593597 6.72 267.28 99.40 2m9s

Copy link
Contributor

@yuwen01 yuwen01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leruaa leruaa merged commit 20c5f23 into dev Nov 16, 2024
13 checks passed
@leruaa leruaa deleted the aurelien/add-program-arg-to-vkey branch November 16, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants