Convert to monorepo using lerna.js #153

mlnmln · 2019-01-02T15:16:39Z

@simonsmith @giuseppeg

Moves suit to a monorepo using lerna.js.
imports all non-deprecated packages with their commit history.
Bootstraps all packages using the yarn client.
Updates mocha in generator-suit and removes pre publishnsp (bc of reported security issue, lerna bootstrap would not finish otherwise).
Updates uris for repo, homepage and bugs in all packages.

Use

lerna bootstrap to install all packages

To test lerna versioning

Use lerna version patch --yes --no-push to test locally before doing anything on remote.

To publish

npm login, then
lerna publish patch --yes

This results in the following version bumps, everything should stay 100% backwards compatible.

 - suitcss-base: 5.0.0 => 5.0.1
 - suitcss-components-arrange: 1.1.1 => 1.1.2
 - suitcss-components-button: 6.0.2 => 6.0.3
 - suitcss-components-flex-embed: 2.0.4 => 2.0.5
 - suitcss-components-grid: 4.0.0 => 4.0.1
 - suitcss-components-test: 1.0.0 => 1.0.1
 - suitcss-components: 2.0.0 => 2.0.1
 - generator-suit: 1.0.2 => 1.0.3
 - suitcss-preprocessor: 4.0.0 => 4.0.1
 - stylelint-config-suitcss: 14.0.0 => 14.0.1
 - stylelint-suitcss: 3.0.0 => 3.0.1
 - suitcss-theme: 1.0.0 => 1.0.1
 - suitcss-utils-after: 1.0.1 => 1.0.2
 - suitcss-utils-align: 1.0.0 => 1.0.1
 - suitcss-utils-before: 1.0.1 => 1.0.2
 - suitcss-utils-display: 1.0.2 => 1.0.3
 - suitcss-utils-flex: 2.0.1 => 2.0.2
 - suitcss-utils-layout: 1.0.1 => 1.0.2
 - suitcss-utils-link: 1.0.1 => 1.0.2
 - suitcss-utils-offset: 1.0.0 => 1.0.1
 - suitcss-utils-position: 1.0.1 => 1.0.2
 - suitcss-utils-size: 2.0.1 => 2.0.2
 - suitcss-utils-text: 1.0.0 => 1.0.1
 - suitcss-utils: 3.0.0 => 3.0.1

This PR is limited in scope intentionally and should be a good foundation for further development work with a monorepo approach.

#151

'adjoining-classes': SUIT is ok with adjoining classes, and requires them for component state. 'compatible-vendor-prefixes': this rule isn't useful and doesn't take into account browser market share (so it keeps warning about vendor-prefixes that you don't want). The framework also favours using a preprocessor to handle and update vendor prefixes automatically.

Everything is covered in the generated component's README

Doesn't provide enough value and inadequate plugin support (for things like code style and not warning about variable syntax).

Fix suitcssgh-3

* Add npm support. * Include latest build tools. * Correct names in manifests. * Update generated test file. * Update code style in generated component.

…ed-pkg Update modules in generated package

Rewrite and Change in generator API Fixes suitcss#4

Rename the package.json template to be extensionless Fixes suitcss#9

Fix: prefix modulePackageName with suitcss-

* package.json template: * Update dependencies * Make 0.1.0 the default ver * Add license * Fix indentation in the lib/*.css templates

Update package.json template

Add year and author name to package.json and LICENSE.md templates

Fix documentation example

Includes latest change to CSS variables syntax.

Fix suitcssgh-1

Updating stylelint to v8

Update stylelint to v9

* growl contained a critical security issue (https://www.npmjs.com/advisories/146) * nsp has been replaced by npm audit * prepublish hook is called by lerna bootstrap

* Prefers yarn.lock over package-lock.json

giuseppeg

thanks @mlnmln !! I took a look at the PR and this is a first round of feedback. Hopefully next week I will have some time to clone and play with it.

giuseppeg · 2019-01-06T15:04:08Z

package.json

@@ -12,6 +12,7 @@
    "suitcss-utils": "^3.0.0"


Currently suitcss/suit is a package on its own. Is it necessary or does it make sense to create a pkg in packages/suit?

#151 (comment)

It is not necessary, but I would recommend moving it to packages/suit. That way the docs could stay at root and the code would be in its own folder.

giuseppeg · 2019-01-06T15:28:57Z

.gitignore

@@ -1,4 +1,3 @@
 bower_components
 build
-components


you didn't remove this from other packages. Should we do for all of them or for none?

lerna version was (wrongfully?) complaining that some packages would be under gitignore, e.g. components-button. It think it would be safe to remove it from all packages. component itself is deprecated for more than 3 years now.

giuseppeg · 2019-01-06T15:30:19Z

packages/base/.travis.yml

@@ -0,0 +1,4 @@
+language: node_js


I think that with the monorepo now we need a centralized .travis.yml config and maybe even a centralized test runner

Agreed, but I would track that in a separate issue.

yep makes sense, thanks!

giuseppeg · 2019-01-06T15:32:12Z

packages/base/.travis.yml

@@ -0,0 +1,4 @@
+language: node_js
+sudo: false
+node_js:


we should normalize this field too. I'd pick node 8 and 10, 6 is going out the LTS maintenance in April.

giuseppeg · 2019-01-06T15:36:21Z

packages/base/README.md

+
+* [npm](http://npmjs.org/): `npm install suitcss-base`
+* [Component(1)](http://github.com/component/component): `component install suitcss/base`
+* [Download](https://github.com/suitcss/base/releases)


probably we should remove these download links

giuseppeg · 2019-01-06T15:36:32Z

packages/base/README.md

+## Installation
+
+* [npm](http://npmjs.org/): `npm install suitcss-base`
+* [Component(1)](http://github.com/component/component): `component install suitcss/base`


will this keep working?

It's not even working right now. :)

mlnmln@localhost ~/d/component> component install suitcss/base installed : suitcss/[email protected] in 2099ms fatal : no remote found for dependency "necolas/[email protected]". Visit http://component.github.io/troubleshooting for help.

having said that. for as long as we keep the original repo and archive it, . component installation should still work.

mlnmln · 2019-01-07T12:49:51Z

@giuseppeg Thanks for the feedback, I added my points.

My main goal now, would be to have a shared understanding of scope / task breakdown.

This PR allows publishing new versions for each package through lerna.js, (hopefully) without breaking anything.

I would strongly recommend splitting any other features (shared test runner, travis config etc., ) into separate issues, unless you think they are critical for landing the PR.

Otherwise we can work on this indefinitely.

simonsmith · 2019-01-07T20:05:24Z

I think this looks good!

This PR is limited in scope intentionally and should be a good foundation for further development work with a monorepo approach.

I agree with this. This work will give us the push to get carry on with other outstanding issues and we can refine the lerna setup as we go.

Great stuff @mlnmln.

One question regarding the root level package.json. If we were to bump and publish say, suitcss-base do we then need to bump the version in the root package.json and publish the suit package?

mlnmln · 2019-01-09T15:33:36Z

@simonsmith

I agree with this. This work will give us the push to get carry on with other outstanding issues and we can refine the lerna setup as we go.

Glad to hear.

One question regarding the root level package.json. If we were to bump and publish say, suitcss-base do we then need to bump the version in the root package.json and publish the suit package?

For as long as we use independent versioning, I don't think so, no.

We would only bump the suit package when we want it to use a new version of suitcss-base outside its current caret range.

But to have that more clearly separated I think we should take action on #153 (comment)

Then we essentially would have a (private) root package that is not suit.
SEE: https://github.com/babel/babel/blob/master/package.json#L3

That package then would take care of shared dev dependencies etc in the long run, but is not installable on its own via npm.

It relatively easy and I could do it during the next couple of days. What do you think?

simonsmith · 2019-01-09T15:46:01Z

But to have that more clearly separated I think we should take action on #153 (comment)

That seems a logical approach to me, yes

mlnmln · 2019-01-10T13:48:48Z

@simonsmith @giuseppeg

I moved suit to its own package now, the root package now only includes lerna.js.
I did not know how to split up the readme for the package exactly, so I left it at root.
In the midterm this should be split into a project and a package readme for the suit package only.
Also I did not touch the links to old the releases for now.

giuseppeg · 2019-01-10T13:54:03Z

In the midterm this should be split into a project and a package readme for the suit package only.

@mlnmln I guess that for now we can duplicate it

mlnmln · 2019-01-10T13:54:57Z

@mlnmln I guess that for now we can duplicate it

works for me.

giuseppeg · 2019-01-10T13:57:41Z

@simonsmith I just pushed a pre-monorepo branch to save a copy of the status quo. Feel free to merge when you've taken a look at the PR.

@mlnmln thank you a lot for your help and patience :)

simonsmith · 2019-01-16T21:24:30Z

Looks great to me. Merging

necolas and others added 30 commits December 30, 2018 14:57

v0.1.0

24af618

Fix the generated README's description placeholder

e95d3d1

v0.1.1

8de9897

Use Component(1) for SUIT package development

861274f

Add 'suit-test' to generated app dev dependencies

cc17d16

v0.2.0

97a9f53

Remove 'testing' section of README

7bee843

Everything is covered in the generated component's README

Remove CSSLint tooling from modules

de66604

Doesn't provide enough value and inadequate plugin support (for things like code style and not warning about variable syntax).

Add 'component-builder-suit' to provided tooling

df571c8

Fix suitcssgh-3

0.3.0

e2997f8

Generate latest package format

68ed0eb

* Add npm support. * Include latest build tools. * Correct names in manifests. * Update generated test file. * Update code style in generated component.

0.4.0

8013152

Merge pull request suitcss#7 from giuseppeg/update-modules-in-generat…

3324128

…ed-pkg Update modules in generated package

0.5.0

c58c828

Merge pull request suitcss#8 from suitcss/rewrite

45199c2

Rewrite and Change in generator API Fixes suitcss#4

1.0.0

87a3076

Merge pull request suitcss#10 from suitcss/fix-npm-package

d1f4d6f

Rename the package.json template to be extensionless Fixes suitcss#9

1.0.1

d672777

Merge pull request suitcss#11 from suitcss/fix/repo-pkg-name

cd8bbc3

Fix: prefix modulePackageName with suitcss-

Merge pull request suitcss#12 from suitcss/fix/misc

0f8ed3a

* package.json template: * Update dependencies * Make 0.1.0 the default ver * Add license * Fix indentation in the lib/*.css templates

1.0.2

4f8e481

Merge pull request suitcss#13 from briandrum/update-package

4372032

Update package.json template

Merge pull request suitcss#15 from briandrum/add-year-and-author-name

e84884f

Add year and author name to package.json and LICENSE.md templates

0.1.1

4da589f

Merge pull request suitcss#2 from simonsmith/doc-update

4e76c46

Fix documentation example

Update 'rework-suit' to 2.0.x

beba1ad

Includes latest change to CSS variables syntax.

Update autoprefixer

ef090e7

0.2.0

4bddfbe

Add 'files' to package.json

12001d7

Fix suitcssgh-1

simonsmith and others added 13 commits December 30, 2018 14:59

Merge pull request suitcss#2 from vidhem/master

619a73f

Updating stylelint to v8

Update yarn.lock

4cc7315

2.0.0

c4ed67f

Merge pull request suitcss#3 from satazor/update-stylelint

43f8bf3

Update stylelint to v9

Remove .nvmrc Rely on Travis to test older versions

c797b2e

3.0.0

6bebbd7

Upgrade mocha, remove pre publish audit

7b71bac

* growl contained a critical security issue (https://www.npmjs.com/advisories/146) * nsp has been replaced by npm audit * prepublish hook is called by lerna bootstrap

Bootstrap all packages

afa4279

* Prefers yarn.lock over package-lock.json

Remove package-lock for components grid

fbde917

Point repository uris to monorepo

afda66d

Point bugtracker uri to monorepo

73a946d

Point homepage uris to monorepo

a11ffe8

Don't ignore components folder (conflicts with lerna version)

767a412

giuseppeg reviewed Jan 6, 2019

View reviewed changes

mlnmln added 3 commits January 10, 2019 14:35

Move suit to its own package

a798a81

Bootstrap packages

a7470d9

Update links to packages

ec4525b

mlnmln changed the title ~~WIP: Convert to monorepo using lerna.js~~ Convert to monorepo using lerna.js Jan 10, 2019

Duplicate readme

67e1469

simonsmith merged commit 64e1f13 into suitcss:master Jan 16, 2019

simonsmith mentioned this pull request Jan 16, 2019

Monorepo #151

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert to monorepo using lerna.js #153

Convert to monorepo using lerna.js #153

mlnmln commented Jan 2, 2019

giuseppeg left a comment

giuseppeg Jan 6, 2019

mlnmln Jan 7, 2019

giuseppeg Jan 6, 2019

mlnmln Jan 7, 2019

giuseppeg Jan 6, 2019

mlnmln Jan 7, 2019

giuseppeg Jan 7, 2019

giuseppeg Jan 6, 2019

giuseppeg Jan 6, 2019

mlnmln Jan 7, 2019

giuseppeg Jan 6, 2019

mlnmln Jan 7, 2019 •

edited

Loading

mlnmln commented Jan 7, 2019 •

edited

Loading

simonsmith commented Jan 7, 2019 •

edited

Loading

mlnmln commented Jan 9, 2019

simonsmith commented Jan 9, 2019

mlnmln commented Jan 10, 2019 •

edited

Loading

giuseppeg commented Jan 10, 2019

mlnmln commented Jan 10, 2019

giuseppeg commented Jan 10, 2019

simonsmith commented Jan 16, 2019

Convert to monorepo using lerna.js #153

Convert to monorepo using lerna.js #153

Conversation

mlnmln commented Jan 2, 2019

giuseppeg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlnmln Jan 7, 2019 • edited Loading

Choose a reason for hiding this comment

mlnmln commented Jan 7, 2019 • edited Loading

simonsmith commented Jan 7, 2019 • edited Loading

mlnmln commented Jan 9, 2019

simonsmith commented Jan 9, 2019

mlnmln commented Jan 10, 2019 • edited Loading

giuseppeg commented Jan 10, 2019

mlnmln commented Jan 10, 2019

giuseppeg commented Jan 10, 2019

simonsmith commented Jan 16, 2019

mlnmln Jan 7, 2019 •

edited

Loading

mlnmln commented Jan 7, 2019 •

edited

Loading

simonsmith commented Jan 7, 2019 •

edited

Loading

mlnmln commented Jan 10, 2019 •

edited

Loading