-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra border around facets on mobile view #1277
Comments
The border line appears to come in from Blacklight: https://github.com/projectblacklight/blacklight/blob/main/app/assets/stylesheets/blacklight/_facets.scss#L52 |
For the border color for the button, would you mind providing a similar example or the color you like? I assume you want btn-primary-outline (or similar) but just want to confirm. Also, I am applying the spacing changes only to the mobile version. Is the correct? Or would you like to change the border color for all window sizes, not just mobile? |
The PR above addresses the section border and spacing, but not the button itself. It might be good to do a different PR overriding the button as a whole/using the component as opposed to just CSS changes. |
Also, the button doesn't exist in the desktop version, so that answers one of my questions above. |
It should use the primary blue outline button seen here - https://sul-dlss.github.io/component-library/button/. Pick a size that's closest to the button that's there now. |
Thanks. For reference, the code for the "show/hide facets" button is here: https://github.com/projectblacklight/blacklight/blob/main/app/components/blacklight/response/facet_group_component.html.erb |
This may have been an inadvertent change in Blacklight projectblacklight/blacklight@3237317. Can we fix it there? |
Actually, it's just easer to set
|
Closed by #1309 |
Each facet has a border, so we do not need to wrap all of them with another border. It's only happening on mobile view. Also, I think we need to center "Limit your search" and the "Show/Hide facets" button vertically. And lastly, if possible, the button should be a primary outline button instead of the default gray.
The text was updated successfully, but these errors were encountered: