Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra border around facets on mobile view #1277

Closed
dbranchini opened this issue Aug 28, 2024 · 9 comments
Closed

Remove extra border around facets on mobile view #1277

dbranchini opened this issue Aug 28, 2024 · 9 comments
Assignees
Labels

Comments

@dbranchini
Copy link

Each facet has a border, so we do not need to wrap all of them with another border. It's only happening on mobile view. Also, I think we need to center "Limit your search" and the "Show/Hide facets" button vertically. And lastly, if possible, the button should be a primary outline button instead of the default gray.

@dbranchini dbranchini added the ui label Aug 28, 2024
@hudajkhan hudajkhan self-assigned this Aug 29, 2024
@hudajkhan
Copy link
Contributor

@hudajkhan
Copy link
Contributor

For the border color for the button, would you mind providing a similar example or the color you like? I assume you want btn-primary-outline (or similar) but just want to confirm.

Also, I am applying the spacing changes only to the mobile version. Is the correct? Or would you like to change the border color for all window sizes, not just mobile?

@hudajkhan
Copy link
Contributor

The PR above addresses the section border and spacing, but not the button itself. It might be good to do a different PR overriding the button as a whole/using the component as opposed to just CSS changes.

@hudajkhan
Copy link
Contributor

Also, the button doesn't exist in the desktop version, so that answers one of my questions above.

@dbranchini
Copy link
Author

It should use the primary blue outline button seen here - https://sul-dlss.github.io/component-library/button/. Pick a size that's closest to the button that's there now.

@hudajkhan
Copy link
Contributor

Thanks. For reference, the code for the "show/hide facets" button is here: https://github.com/projectblacklight/blacklight/blob/main/app/components/blacklight/response/facet_group_component.html.erb

@jcoyne
Copy link
Contributor

jcoyne commented Aug 30, 2024

This may have been an inadvertent change in Blacklight projectblacklight/blacklight@3237317. Can we fix it there?

@jcoyne
Copy link
Contributor

jcoyne commented Aug 30, 2024

Actually, it's just easer to set

.facets-header {
  --bl-facets-smallish-border: none;
  --bs-navbar-toggler-border-color: var(--stanford-digital-blue);
  --bs-navbar-color: var(--stanford-digital-blue);
}

@hudajkhan
Copy link
Contributor

Closed by #1309

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

4 participants