Removing border from facet section, changing spacing of heading and button #1309
Conversation
fix blacklight solr url location
use bootstrap.bundle instead of bootstrap
update header to stanford header
add footer
Now that geoblacklight/geoblacklight#1441 has been merged we should probably be using main?
Use geoblacklight main
Revise text and layout for search widgets on small screens
reorder and rename facets
switch to arrow-circle-fill
hudajkhan
force-pushed
the
bl8-mobileborder
branch
from
31047f2
to
53fa56f
Compare
Double search
Change padding and alignment for search bar
remove bl7 form, update form to use user info
Update the geoblacklight frontend package to v5.0.0-alpha.10
Stop namespacing components
Add a comment to understand why a style was needed
make box shadow appear on right and left
hudajkhan
force-pushed
the
bl8-mobileborder
branch
from
081de15
to
03e67c3
Compare
| --bl-facets-smallish-border: none; | ||
| --bs-navbar-toggler-border-color: var(--stanford-digital-blue); | ||
| --bs-navbar-color: var(--stanford-digital-blue); | ||
| color: var(--stanford-digital-blue); |
There was a problem hiding this comment.
is this color necessary? This rule should apply:
.navbar-toggler {
...
color: var(--bs-navbar-color);
}
There was a problem hiding this comment.
For whatever reason, it doesn't work with just the "--bs-navbar-color" definition.The "color" property is set explicitly elsewhere, so --bs-navbar-color isn't the only thing determining the color.
| } | ||
|
|
||
| .facets-header .navbar-toggler:hover { | ||
| color: var(--stanford-digital-blue-dark); |
There was a problem hiding this comment.
We should make this settable in blacklight: https://github.com/projectblacklight/blacklight/blob/69373f202753f04ec6aca179fdf8fa01248a9edf/app/assets/stylesheets/blacklight/_facets.scss#L22-L25
There was a problem hiding this comment.
Do you mean, for example, make a variable specifically for the hover color in Blacklight, so we can just override that variable value?
|
To make the rebase to main easier, and to get this moving along, I am going to close this PR and open up two new ones: |
Addresses #1277
To remove the border around the facet section for the mobile view, we override the border value for .facets-toggleable-md. To vertically align the heading and the button, we remove some padding and margin values that were pushing the text further below.