-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move tools to header #1229
move tools to header #1229
Conversation
d14d804
to
eb39ea1
Compare
1610f30
to
d895359
Compare
d895359
to
a5c346c
Compare
@@ -1,3 +1,3 @@ | |||
@import 'bootstrap/scss/bootstrap'; | |||
@import 'blacklight-frontend/app/assets/stylesheets/blacklight/blacklight'; | |||
@import 'blacklight/blacklight'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it ok to commit this change and the bin/build-css
file? (not questioning it so much as verifying it's ok)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to remember to undo it, but I think it's OK
can we throw a comment in the gemfile near the pin to |
@@ -61,7 +61,8 @@ group :production do | |||
gem 'pg' | |||
end | |||
|
|||
gem 'blacklight', '~> 8.3' | |||
#gem 'blacklight', '~> 8.3' | |||
gem 'blacklight', github: 'projectblacklight/blacklight', branch: 'main' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After release
- remove line 65, comment back in 64
- In app/assets/stylesheets/geoblacklight.scss change @import 'blacklight/blacklight'; to @import 'blacklight-frontend/app/assets/stylesheets/blacklight/blacklight';
- remove bin/build-css
- update package.json scripts to
"build:css": "sass ./app/assets/stylesheets/geoblacklight.scss:./app/assets/builds/geoblacklight.css --load-path=node_modules"
The line going past the tools looks fine. I guess what bothers me a little is that the line aligns with the map on the right, but it doesn't align with the sidebar on the left. The lack of underline should be fine. In cases where the link is within a body of text, it should be accompanied by an indicator (in addition to color) to signify that it's a link. I don't think it applies here. |
I am going to open a separate ticket for that, just so we can get this in. |
closes #673
@dbranchini This can't go into production until backlight is released but if you want you can review the screenshots attached to this PR. Also there are two differences I can see from the Figma that I didn't address for the following reasons.