Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the footer to the bottom on a tall screen #1320

Closed
wants to merge 1 commit into from
Closed

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Aug 30, 2024

Fixes #1290

@jcoyne jcoyne changed the title Force the header to the bottom on a tall screen Force the footer to the bottom on a tall screen Aug 30, 2024
@@ -4,6 +4,11 @@
--stanford-palo-alto-rgb: 23, 94, 84;
}

#main-container {
/* force the footer to the bottom on a tall viewport */
min-height: calc(100vh - 323px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the source of 323?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Header height + footer height.

Base automatically changed from bl8 to main August 30, 2024 22:33
@thatbudakguy
Copy link
Member

@jcoyne the way I usually do this is #1352 because it avoids needing to calculate a pixel value. sorry for not specifying that in the ticket

@thatbudakguy thatbudakguy deleted the view-height branch September 5, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homepage main container does not expand to fill page
3 participants