Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1329 map collapse #1334

Merged
merged 1 commit into from
Sep 4, 2024
Merged

1329 map collapse #1334

merged 1 commit into from
Sep 4, 2024

Conversation

dnoneill
Copy link
Contributor

@dnoneill dnoneill commented Aug 30, 2024 •
edited
Loading

closes #1329
Screenshot 2024-08-30 at 3 14 19 PM
Screenshot 2024-08-30 at 3 14 13 PM
Screenshot 2024-08-30 at 3 13 56 PM
Screenshot 2024-08-30 at 3 12 49 PM

@dnoneill dnoneill force-pushed the 1329-map-collapse branch 5 times, most recently from 90c8b97 to 92eddfd Compare August 30, 2024 19:15
@marlo-longley
Copy link
Contributor

marlo-longley commented Aug 30, 2024 •
edited
Loading

This is great. Any chance we can get the button to look more like the Figma?
Even if we can't get the purely outlined icon, changing the color to blue and shrinking it would help I think.

Screenshot 2024-08-30 at 15 58 05 vs. Screenshot 2024-08-30 at 15 58 51

@dnoneill
Copy link
Contributor Author

Screenshot 2024-08-30 at 4 10 13 PM

Updated view. Good catch.

@marlo-longley
Copy link
Contributor

Does the Search using map button have a toggled on/off state? As in, if you click it and open the map, should the button change style at all? Currently it does not.

@dnoneill
Copy link
Contributor Author

I didn't see one in the figma and the facets don't have one in figma so I figured we could update later it if we heard it has a state from Darcy.

Base automatically changed from bl8 to main August 30, 2024 22:33
@jcoyne
Copy link
Contributor

jcoyne commented Sep 3, 2024

@dnoneill this needs a rebase

@dnoneill dnoneill force-pushed the 1329-map-collapse branch 2 times, most recently from 504bd19 to ef161f3 Compare September 4, 2024 15:35
@dnoneill
Copy link
Contributor Author

dnoneill commented Sep 4, 2024

@jcoyne Done.

@thatbudakguy thatbudakguy merged commit b87598b into main Sep 4, 2024
2 checks passed
@thatbudakguy thatbudakguy deleted the 1329-map-collapse branch September 4, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marlo-longley marlo-longley marlo-longley left review comments

@thatbudakguy thatbudakguy thatbudakguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

have map collapse on medium screens.
4 participants
@dnoneill @marlo-longley @jcoyne @thatbudakguy