Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify RecentlyAddedListComponent and its copy #1337

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

marlo-longley
Copy link
Contributor

@marlo-longley marlo-longley commented Aug 30, 2024

Closes #1316

Screenshot 2024-08-30 at 15 36 51

@marlo-longley
Copy link
Contributor Author

I could be convinced that testing for expect(component.count).to eq(13) hardcoded is a bad idea and will make adding unrelated new docs annoying in the future. I just wanted to make sure the component was working.

@dnoneill
Copy link
Contributor

Why would it be over (that number should be exact). Shouldn't it just be There are 36 datasets?

@marlo-longley
Copy link
Contributor Author

I just mean if I'm working on something else and add a new fixture, this test will fail and be annoying.

@dnoneill
Copy link
Contributor

No sorry that wasn't clear. The copy says There are over <b>%{sets} datasets</b> in EarthWorks. but that isn't actually correct there are exactly %{sets} not over.

@marlo-longley
Copy link
Contributor Author

I seeeee. Thanks!

@marlo-longley
Copy link
Contributor Author

@dnoneill fixed.

Base automatically changed from bl8 to main August 30, 2024 22:33
@jcoyne
Copy link
Contributor

jcoyne commented Sep 3, 2024

@marlo-longley this needs a rebase

@thatbudakguy thatbudakguy force-pushed the home-text-2 branch 2 times, most recently from cf9f538 to 0e003d7 Compare September 4, 2024 16:47
@thatbudakguy
Copy link
Member

I just mean if I'm working on something else and add a new fixture, this test will fail and be annoying.

Seems like this is exactly what happened. I'm going to just remove that test.

@thatbudakguy thatbudakguy merged commit 86e0f37 into main Sep 4, 2024
2 checks passed
@thatbudakguy thatbudakguy deleted the home-text-2 branch September 4, 2024 17:31
@marlo-longley
Copy link
Contributor Author

Perfect, thank you for covering Nick!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy for the home page
4 participants