Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1346 Make facet buttons blue #1346

Closed
wants to merge 1 commit into from
Closed

Conversation

peetucket
Copy link
Member

Fixes #1340

Looks like this in PR:

Screenshot 2024-08-30 at 3 37 31 PM
Screenshot 2024-08-30 at 3 37 35 PM

@peetucket peetucket changed the title Make facet buttons blue 1346 Make facet buttons blue Aug 30, 2024
@@ -313,3 +313,21 @@ label.toggle-bookmark {
--bs-link-color-rgb: var(--stanford-digital-blue-dark-rgb);
text-decoration: underline;
}

.constraint-value.btn-outline-secondary {
Copy link
Contributor

@jcoyne jcoyne Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secondary is defined as red in the component library. Can you change the class to be btn-outline-primary instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@jcoyne
Copy link
Contributor

jcoyne commented Sep 3, 2024

This seems to be in conflict with what is asked for in #1355

@peetucket
Copy link
Member Author

This seems to be in conflict with what is asked for in #1355

Indeed it does -- I didn't see the figma design when doing this ticket. Closing this PR and the associated ticket.

@peetucket peetucket closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map facet buttons blue not red
2 participants