1343 Make expand/collapse buttons blue #1347
Conversation
| @@ -208,10 +208,13 @@ Uncomment lines 142-144 | |||
|
|
|||
| .expand-collapse .btn-outline-secondary { | |||
There was a problem hiding this comment.
It's really odd that we're changing secondary buttons to be blue. The component library defines "primary" as the blue color. Is there a reason we can't change the class?
There was a problem hiding this comment.
There was a problem hiding this comment.
I think it makes sense to use the btn-outline-primary class to get the blue color we want without redefining what the -secondary button color is (even if targeted to just these particular buttons), but unless I'm missing something we still need to specify the blue background/white foreground when active for just the expand/collapse buttons (which the stylesheet change is targeted to).
I just pushed a commit to do this.
| color: white; | ||
| background-color:var(--stanford-cardinal); | ||
| } | ||
| --bs-btn-hover-color: var(--stanford-digital-blue-dark); |
There was a problem hiding this comment.
None of these are necessary anymore, right? Isn't this the default?
There was a problem hiding this comment.
There was a problem hiding this comment.
I just reviewed, and you are right that several are default in the component library and can be removed. But the active button turning solid blue isn't the default and I think it's what is requested. So I think a couple overrides are still relevant.
There was a problem hiding this comment.
Actually, was able to adjust the existing &.active definition to be blue instead of red. Seemed to do it.
peetucket
force-pushed
the
1343-expand-collapse-blue
branch
2 times, most recently
from
197df6e
to
19fd242
Compare
peetucket
force-pushed
the
1343-expand-collapse-blue
branch
from
19fd242
to
a7b9767
Compare
Fixes #1341 - make expand/collapse buttons blue
With this PR: