Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Blacklight 8.4.0 #1415

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Upgrade to Blacklight 8.4.0 #1415

merged 1 commit into from
Oct 30, 2024

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Sep 18, 2024

closes #1282

@dnoneill
Copy link
Contributor

Approved, not sure if we want to point the css on npm and not build from gem https://github.com/sul-dlss/earthworks/pull/1229/files#r1735246549. Granted vt-arclight does this and it might not matter in the gem is stable?

@thatbudakguy
Copy link
Member

@dnoneill can you clarify what you meant here? Don't we always have to build the styles from npm?

@dnoneill
Copy link
Contributor

@thatbudakguy See comment here: https://github.com/sul-dlss/earthworks/pull/1229/files#r1735246549. This PR doesn't remove the build-css script. We used to pull directly from npm not the gem.

@thatbudakguy
Copy link
Member

Ah, thanks for explaining. Honestly, pulling from the gem makes it easier to get updates more quickly, and since few other people are working on the 5.x branch, it might be beneficial for the time being...

@thatbudakguy thatbudakguy merged commit 9d7550d into main Oct 30, 2024
2 checks passed
@thatbudakguy thatbudakguy deleted the upgrade-blacklight-8 branch October 30, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin to a stable ref for blacklight in the Gemfile
3 participants