Merge pull request #985 from sul-dlss/migrate-err

Move MIGRATE-ERR suppression into FolioRecord#sirsi_holdings instead of in the query
sul-dlss · Jul 18, 2023 · 5ce9d04 · 5ce9d04
2 parents 8a055c3 + efd377f
commit 5ce9d04
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/lib/folio_record.rb b/lib/folio_record.rb
@@ -76,6 +76,8 @@ def sirsi_holdings
       holding = holdings.find { |holding| holding['id'] == item['holdingsRecordId'] }
       item_location_code = item.dig('location', 'permanentLocation', 'code')
       item_location_code ||= holding.dig('location', 'permanentLocation', 'code')
+      next if item_location_code&.end_with? 'MIGRATE-ERR'
+
       library_code, home_location_code = LocationsMap.for(item_location_code)
       _current_library, current_location = LocationsMap.for(item.dig('location', 'location', 'code'))
       current_location ||= folio_status_to_location(item['status'])

diff --git a/lib/traject/readers/folio_postgres_reader.rb b/lib/traject/readers/folio_postgres_reader.rb
@@ -21,12 +21,7 @@ def self.find_by_catkey(catkey, settings = {})
     end
 
     def default_filters
-      [suppress_shadowed_items, @settings['postgres.sql_filters']].compact
-    end
-
-    # exclude things that are shadowed in symphony, which are in locations that don't get mapped and thus end up in the "migration error" locations.
-    def suppress_shadowed_items
-      "item.effectivelocationid NOT IN (SELECT id from location WHERE jsonb ->> 'code' like '%MIGRATE-ERR')"
+      [@settings['postgres.sql_filters']].compact
     end
 
     def queries