geo_aardvark_config.rb: add_date_hierarchy_sm field #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this field is meant to support hierarchical date faceting in blacklight. see sul-dlss/earthworks#1136
jmartin-sul
changed the title
jmartin-sul
force-pushed
the
aardvarkDateHierarchy
branch
from
37766bf
to
11f518a
Compare
jmartin-sul
commented
Sep 6, 2024
| # "Obsolete. to take a tenth of or from." - https://www.dictionary.com/browse/decimate | ||
| # | ||
| # @param maybe_year [Integer] an int that (hopefully) represents a year | ||
| def self.centimate_and_decimate(maybe_year) |
There was a problem hiding this comment.
alternatively, i could pick a less precious and slightly wordier name, like extract_century_and_year_strings
There was a problem hiding this comment.
i enjoy this type of thing now and then, tbh
thatbudakguy
approved these changes
Sep 6, 2024
marlo-longley
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
required for sul-dlss/earthworks#1315 to work
part of sul-dlss/earthworks#1136