Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map SUL/SDR location to SUL/INTERNET for parity #957

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Map SUL/SDR location to SUL/INTERNET for parity #957

merged 1 commit into from
Jul 5, 2023

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jul 5, 2023

Fixes #938

cbeer
cbeer reviewed Jul 5, 2023
View reviewed changes
lib/folio/eresource_holdings_builder.rb Outdated
@@ -85,7 +85,8 @@ def barcode(index)
end

def home_location_code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we push this into LocationsMap, where we're already doing some of this location code massaging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about into locations.tsv?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we were trying to keep our locations.tsv in sync with what libsys is using.

cbeer
cbeer reviewed Jul 5, 2023
View reviewed changes
lib/translation_maps/locations.tsv Outdated
@@ -449,4 +449,4 @@ SSRC-FIC-S GREEN GRE-DOCS-MICROFICHE
SDR LAW LAW-SDR
SDR BUSINESS BUS-SDR
SDR HOOVER HILA-SDR
SDR SUL SUL-SDR
INTERNET SUL SUL-SDR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Copied from the outdated thread)

I thought we were trying to keep our locations.tsv in sync with what libsys is using.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 are we documenting that somewhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, anywhere you think would be appropriate. It seems like a very good idea not to change that upstream data.

@cbeer cbeer merged commit 1f9bbed into main Jul 5, 2023
@cbeer cbeer deleted the sdr-is-internet branch July 5, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeer cbeer cbeer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Map SUL/SDR location to SUL/INTERNET for parity
2 participants
@jcoyne @cbeer